feat: special negative-conditional cache for two properties that are very important for princess calculations #6463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…very important for Princess calculations
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6463 +/- ##
=========================================
Coverage 28.59% 28.59%
- Complexity 14377 14384 +7
=========================================
Files 2798 2798
Lines 274895 274904 +9
Branches 48630 48631 +1
=========================================
+ Hits 78593 78606 +13
+ Misses 191669 191663 -6
- Partials 4633 4635 +2 ☔ View full report in Codecov by Sentry. |
HammerGS
added
the
For New Dev Cycle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this property only caches
false, any other value and it will have to recalculate itself every time until it turns to false. So, for the most part, it is going to be fast.Also, it looks like it has no side-effects on other places since other places rely on the unit during gameplay, or loading it directly from a file.
There is also a reset builtin the property to make sure it is renewed every turn, so if it does not have the property it will calculate it at least once.
It still needs some more information on the API of the methods to explain why and how, and better testing from my part, comparing with and without the variable enabled.